Skip to content

Conversation

@ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Oct 30, 2025

Related to #3002

Changes

This PR defines roles for k8s entities' attributes.

Note: k8s.container and k8s.namespace are left out for now cause they don't define a uid identifying attribute which quite straight-forward to use. They are marked as TODO though for now.

Merge requirement checklist

  • CONTRIBUTING.md guidelines followed.
  • Change log entry added, according to the guidelines in When to add a changelog entry.
    • If your PR does not need a change log, start the PR title with [chore]
  • Links to the prototypes or existing instrumentations (when adding or changing conventions)

@ChrsMark ChrsMark requested review from a team as code owners October 30, 2025 10:18
@github-actions github-actions bot added enhancement New feature or request area:k8s labels Oct 30, 2025
@ChrsMark ChrsMark changed the title [k8s] refine attribute roles for k8s entities [k8s] define attribute roles for k8s entities Oct 30, 2025
@github-project-automation github-project-automation bot moved this from Untriaged to Needs More Approval in Semantic Conventions Triage Nov 3, 2025
@lmolkova lmolkova moved this from Needs More Approval to Ready to be Merged in Semantic Conventions Triage Nov 3, 2025
@lmolkova
Copy link
Member

lmolkova commented Nov 3, 2025

@ChrsMark could you please resolve conflicts? Otherwise it's ready to go (ownership check is having hard time for some unrelated reasons, it's not a required check though)

@ChrsMark
Copy link
Member Author

ChrsMark commented Nov 3, 2025

@lmolkova sure, I have rebased this. Should be fine now.

@lmolkova lmolkova added this pull request to the merge queue Nov 3, 2025
Merged via the queue into open-telemetry:main with commit d28c6dc Nov 3, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:k8s enhancement New feature or request

Projects

Status: Done
Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants